lib/sandboxes/uploadSandboxFiles.ts (1)

39-65: ⚠️ Potential issue | 🟠 Major

Partial blob upload failures are swallowed instead of being returned to callers.

With Promise.allSettled, rejected uploads are filtered out, but their messages are never added to the returned errors. In mixed outcomes, this can hide failures from the UI even though some files failed at blob upload time.

Proposed fix

 export async function uploadSandboxFiles({
@@
 }): Promise<{ uploaded: UploadedFile[]; errors?: string[] }> {
   const results = await Promise.allSettled(
@@
   const blobFiles = results
@@
     .map((r) => r.value);
+
+  const blobUploadErrors = results
+    .filter((r): r is PromiseRejectedResult => r.status === "rejected")
+    .map((r) =>
+      r.reason instanceof Error
+        ? r.reason.message
+        : String(r.reason ?? "Failed to upload file to temporary storage"),
+    );
 
   if (blobFiles.length === 0) {
-    const firstError = results.find((r) => r.status === "rejected") as
-      | PromiseRejectedResult
-      | undefined;
     throw new Error(
-      firstError?.reason?.message ||
-        "Failed to upload files to temporary storage",
+      blobUploadErrors[0] || "Failed to upload files to temporary storage",
     );
   }
@@
-  return {
-    uploaded: data.uploaded || [],
-    errors: data.errors,
-  };
+  const allErrors = [...blobUploadErrors, ...(data.errors ?? [])];
+  return {
+    uploaded: data.uploaded || [],
+    ...(allErrors.length ? { errors: allErrors } : {}),
+  };
 }

As per coding guidelines, lib/**/*.ts utility functions must provide proper error handling.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@lib/sandboxes/uploadSandboxFiles.ts` around lines 39 - 65, The current
Promise.allSettled handling drops rejected upload results so partial failures
are hidden; update the logic in uploadSandboxFiles (the block using
Promise.allSettled, results, blobFiles and upload) to collect rejected entries
from results, map them to structured error messages (including file.name and
rejection reason), and if any rejections exist return or throw an AggregateError
(or Error) that includes both the list of successfully uploaded blobFiles and a
detailed array/string of failed files and their error messages so callers can
surface partial-failure info to the UI.